Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the "hydrostatic" Skamarock-Klemp gravity wave and "hydrostatic" mountain tests into this repo (and out of the main gusto repo).
Each test is now implemented with a
hydrostatic
argument, so that all tests can be run with hydrostatic or non-hydrostatic equation sets.The "non-hydrostatic" mountain also has the
hydrostatic
argument added.Still to do:
mountain_hydrostatic
test. It's not clear whether this is a problem with the initial conditions...Add or update a Gusto case study
Here is a checklist of things that should be done to add a new case study to
the repository:
templates/template_case_study.py
. This ensures that the case study:__main__
routine with arg-parsing of command line argumentstest_*.py
file, so that it will be run as part of CIplotting
directory, with a name that matches the case study scriptfigures
directory, with names that match the case study scriptAdd or update a plotting script
Here is a checklist of things that should be done to add a new plotting script to the repository:
templates/template_plotting_script.py
or another acceptable plotting scripttomplot/good_plot_guide.md